[DO NOT MERGE] Use JavaScript enhanced file upload component#2009
Draft
stephencdaly wants to merge 2 commits intomainfrom
Draft
[DO NOT MERGE] Use JavaScript enhanced file upload component#2009stephencdaly wants to merge 2 commits intomainfrom
stephencdaly wants to merge 2 commits intomainfrom
Conversation
Pass in `javascript: true` to the file component to use the JavaScript enhanced file upload component. This is using placeholder translations copied from some examples in the govuk-frontend repository that are not production ready. We need to update with verified translations before we can merge this. Requires a new release of govuk-formbuilder with x-govuk/govuk-form-builder@b156fe7
With javascript enabled, the file input is hidden and replaced with a custom file upload component. Update the test to expect a hidden file input. As the label is no longer attached to the file input, don't provide a "locator" argument to `attach_file` and allow it to find the only file input on the page.
Contributor
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2009.submit.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/Nqxmi2b6
Pass in
javascript: trueto the file component to use the JavaScript enhanced file upload component.This is using placeholder translations copied from some examples in the govuk-frontend repository that are not production ready. We need to update with verified translations before we can merge this.
Requires a new release of govuk-formbuilder with
x-govuk/govuk-form-builder@b156fe7
Things to consider when reviewing